https://gitlab.synchro.net/main/sbbs/-/commit/4dd32231f18bcb4f67833c36
Modified Files:
exec/load/binkp.js
Log Message:
Resolve undetected or infinitely-retried socket-send failures

My hub (1:218/700) is currently having what appears to be a TCP/IP
connectivity issue that was resulting in infinite "Send failure"
log messages and "We got an M_EOB, but there are still N files pending M_GOT" log messages.

I first added better socket-send failure detection (checking return value of sendCmd() and sendData() where needed) and then noticed that failure to send
a file was not detected (the sending.file.position is advanced even if sendData() fails), so now handling that condition too.

Also added more diagnostics around socket-send failures (is socket writable?) in this particular case, the socket is not writable and socket-send is returning 0.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/c3a41492a79aa3c6b3a41b37
Modified Files:
exec/load/binkp.js
Log Message:
More errno details in file open and socket-send failure warning log msgs

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0ea1ce1d2600b79a77d41b7e
Modified Files:
exec/load/binkp.js
Log Message:
Use socket.poll() to check socket for writability before send()

This is the real fix for infinite-wait on send() problem that was attempted
in commit f0127e9d457, but caused other issues. Thanks Deuce.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8533474761891eeb8d75eddd
Modified Files:
exec/load/binkp.js
Log Message:
Don't log BinkP errors in the error.log

The sysop has no control over what misconfigured remote sysop connects to his BinkP service and sends whatever, so don't log received errors as errors, filling up the sysop's error log and potentially email inbox.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ff46f601780b4e933404ebb3
Modified Files:
exec/load/binkp.js
Log Message:
Also use a timeout if we have nothing to send.

Fixes an infinite loop where there is nothing to send because the
remote does not have the address you are calling to deliver a message
for.

For example if W6RAY just joined the BBSDev FTN, and was assigned
885:1/99, and a netmail was created welcoming the BBS to the network,
but they didn't add the new address to the AKA list in scfg, binkit
would sit using 100% CPU.

Now it sets the timeout, so sits at 0% CPU for 120s then fails.

This is still likely wrong, but at least it's wrong in a much less
harmful way.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/d073484d6bfa3aaba8de4027
Modified Files:
exec/load/binkp.js
Log Message:
Fix error in previous commit regarding no files.

sending will be undefined after a file completes transfer, so the
previous fix resulted in only the first file being trasnferred.

Ensure tx queue is zero-length before setting the timeout.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1c53d34a7db001fdfc2a850d
Modified Files:
exec/load/binkp.js
Log Message:
Log ssh-chatter binkp chat messages

See who's derping our dope.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/92ecc21be9b5c3cd825fa9b1
Modified Files:
exec/load/binkp.js
Log Message:
Fix two-minute timeout when answering and no files

Regression introduced in ff46f601, where the answering system would
not send an M_EOB and instead perform a timeout.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net